From 0772448cd9e7e99e48a44e98a44a21f79ca9c88f Mon Sep 17 00:00:00 2001 From: Yaakov Date: Tue, 27 Aug 2024 20:22:16 +1000 Subject: [PATCH 1/3] Add ContinuousIntegrationBuild to CI --- .github/workflows/build.yml | 2 +- .github/workflows/sk2-ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fbb4ad75..686a2cb5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -33,7 +33,7 @@ jobs: dotnet-version: 8.0.x - name: Build - run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts + run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts /p:ContinuousIntegrationBuild=true - name: Upload artifact uses: actions/upload-artifact@v4 diff --git a/.github/workflows/sk2-ci.yml b/.github/workflows/sk2-ci.yml index 405b31d7..b7463d9c 100644 --- a/.github/workflows/sk2-ci.yml +++ b/.github/workflows/sk2-ci.yml @@ -30,7 +30,7 @@ jobs: dotnet add DepotDownloader/DepotDownloader.csproj package SteamKit2 --prerelease - name: Build - run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts + run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts /p:ContinuousIntegrationBuild=true - name: Upload artifact uses: actions/upload-artifact@v4 From b1a36462cc85af50deaee0ead3cf86724ed9c372 Mon Sep 17 00:00:00 2001 From: Yaakov Date: Tue, 27 Aug 2024 20:24:31 +1000 Subject: [PATCH 2/3] Enable warnings as errors in CI --- DepotDownloader/DepotDownloader.csproj | 1 + 1 file changed, 1 insertion(+) diff --git a/DepotDownloader/DepotDownloader.csproj b/DepotDownloader/DepotDownloader.csproj index 319e2818..7d16e695 100644 --- a/DepotDownloader/DepotDownloader.csproj +++ b/DepotDownloader/DepotDownloader.csproj @@ -10,6 +10,7 @@ Copyright © SteamRE Team 2024 ..\Icon\DepotDownloader.ico true + true From fa486d1e5fb69c20064828202c597106c6f449b3 Mon Sep 17 00:00:00 2001 From: Yaakov Date: Tue, 27 Aug 2024 20:26:19 +1000 Subject: [PATCH 3/3] even though we will probably never run on XP, this silences CA1416 --- DepotDownloader/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DepotDownloader/Program.cs b/DepotDownloader/Program.cs index a71a0fb6..91b8790a 100644 --- a/DepotDownloader/Program.cs +++ b/DepotDownloader/Program.cs @@ -22,7 +22,7 @@ namespace DepotDownloader { PrintUsage(); - if (OperatingSystem.IsWindows()) + if (OperatingSystem.IsWindowsVersionAtLeast(5, 0)) { PlatformUtilities.VerifyConsoleLaunch(); }