Optimize calculating adler hashes to not allocate entire chunk in memory

DepotDownloader/ContentDownloader.cs

@@ -1059,10 +1059,18 @@ namespace DepotDownloader
                             {
                                 fsOld.Seek((long)match.OldChunk.Offset, SeekOrigin.Begin);
 
-                                var tmp = new byte[match.OldChunk.UncompressedLength];
+                                uint a = 0, b = 0;
-                                fsOld.Read(tmp, 0, tmp.Length);
+
+                                for (var i = 0; i < match.OldChunk.UncompressedLength; i++)
+                                {
+                                    var c = (uint)fsOld.ReadByte();
+
+                                    // adler hash
+                                    a = (a + c) % 65521;
+                                    b = (b + a) % 65521;
+                                }
 
-                                var adler = Util.AdlerHash(tmp);
+                                var adler = BitConverter.GetBytes(a | (b << 16));
                                 if (!adler.SequenceEqual(match.OldChunk.Checksum))
                                 {
                                     neededChunks.Add(match.NewChunk);
@@ -1191,7 +1199,7 @@ namespace DepotDownloader
             var depot = depotFilesData.depotDownloadInfo;
             var depotDownloadCounter = depotFilesData.depotCounter;
 
-            var chunkID = Util.EncodeHexString(chunk.ChunkID);
+            var chunkID = Convert.ToHexString(chunk.ChunkID).ToLowerInvariant();
 
             var data = new DepotManifest.ChunkData
             {

DepotDownloader/Util.cs

@@ -78,26 +78,23 @@ namespace DepotDownloader
         public static List<ProtoManifest.ChunkData> ValidateSteam3FileChecksums(FileStream fs, ProtoManifest.ChunkData[] chunkdata)
         {
             var neededChunks = new List<ProtoManifest.ChunkData>();
-            int read;
 
             foreach (var data in chunkdata)
             {
-                var chunk = new byte[data.UncompressedLength];
                 fs.Seek((long)data.Offset, SeekOrigin.Begin);
-                read = fs.Read(chunk, 0, (int)data.UncompressedLength);
 
-                byte[] tempchunk;
+                uint a = 0, b = 0;
-                if (read < data.UncompressedLength)
+
-                {
+                for (var i = 0; i < data.UncompressedLength; i++)
-                    tempchunk = new byte[read];
-                    Array.Copy(chunk, 0, tempchunk, 0, read);
-                }
-                else
                 {
-                    tempchunk = chunk;
+                    var c = (uint)fs.ReadByte();
+
+                    // adler hash
+                    a = (a + c) % 65521;
+                    b = (b + a) % 65521;
                 }
 
-                var adler = AdlerHash(tempchunk);
+                var adler = BitConverter.GetBytes(a | (b << 16));
                 if (!adler.SequenceEqual(data.Checksum))
                 {
                     neededChunks.Add(data);
@@ -107,18 +104,6 @@ namespace DepotDownloader
             return neededChunks;
         }
 
-        public static byte[] AdlerHash(byte[] input)
-        {
-            uint a = 0, b = 0;
-            for (var i = 0; i < input.Length; i++)
-            {
-                a = (a + input[i]) % 65521;
-                b = (b + a) % 65521;
-            }
-
-            return BitConverter.GetBytes(a | (b << 16));
-        }
-
         public static byte[] DecodeHexString(string hex)
         {
             if (hex == null)
@@ -133,13 +118,6 @@ namespace DepotDownloader
             return bytes;
         }
 
-        public static string EncodeHexString(byte[] input)
-        {
-            return input.Aggregate(new StringBuilder(),
-                (sb, v) => sb.Append(v.ToString("x2"))
-            ).ToString();
-        }
-
         /// <summary>
         /// Decrypts using AES/ECB/PKCS7
         /// </summary>