Merge pull request #530 from SteamRE/warnings

Fix warnings, enable Warnings as Errors
1 year ago · a3725da282
parent b5d4926f1e fa486d1e5f
commit a3725da282
4 changed files with 4 additions and 3 deletions
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@ -33,7 +33,7 @@ jobs:
          dotnet-version: 8.0.x

      - name: Build
-        run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts
+        run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts /p:ContinuousIntegrationBuild=true

      - name: Upload artifact
        uses: actions/upload-artifact@v4
--- a/.github/workflows/sk2-ci.yml
+++ b/.github/workflows/sk2-ci.yml
@ -30,7 +30,7 @@ jobs:
          dotnet add DepotDownloader/DepotDownloader.csproj package SteamKit2 --prerelease

      - name: Build
-        run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts
+        run: dotnet publish DepotDownloader/DepotDownloader.csproj -c ${{ matrix.configuration }} -o artifacts /p:ContinuousIntegrationBuild=true

      - name: Upload artifact
        uses: actions/upload-artifact@v4
--- a/DepotDownloader/DepotDownloader.csproj
+++ b/DepotDownloader/DepotDownloader.csproj
@ -10,6 +10,7 @@
    <Copyright>Copyright © SteamRE Team 2024</Copyright>
    <ApplicationIcon>..\Icon\DepotDownloader.ico</ApplicationIcon>
    <Deterministic>true</Deterministic>
+    <TreatWarningsAsErrors Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</TreatWarningsAsErrors>
  </PropertyGroup>

  <ItemGroup>
--- a/DepotDownloader/Program.cs
+++ b/DepotDownloader/Program.cs
@ -22,7 +22,7 @@ namespace DepotDownloader
            {
                PrintUsage();

-                if (OperatingSystem.IsWindows())
+                if (OperatingSystem.IsWindowsVersionAtLeast(5, 0))
                {
                    PlatformUtilities.VerifyConsoleLaunch();
                }