Added persistent content server penalty

DepotDownloader/ConfigStore.cs

@@ -17,12 +17,16 @@ namespace DepotDownloader
         [ProtoMember(3, IsRequired=false)]
         public Dictionary<string, byte[]> SentryData { get; private set; }
 
+        [ProtoMember(4, IsRequired = false)]
+        public System.Collections.Concurrent.ConcurrentDictionary<string, int> ContentServerPenalty { get; private set; }
+
         string FileName = null;
 
         ConfigStore()
         {
             LastManifests = new Dictionary<uint, ulong>();
             SentryData = new Dictionary<string, byte[]>();
+            ContentServerPenalty = new System.Collections.Concurrent.ConcurrentDictionary<string, int>();
         }
 
         static bool Loaded

DepotDownloader/ContentDownloader.cs

@@ -461,6 +461,8 @@ namespace DepotDownloader
 
         private static BlockingCollection<CDNClient> CollectCDNClientsForDepot(DepotDownloadInfo depot)
         {
+            Console.WriteLine("Finding content servers...");
+
             var cdnClients = new BlockingCollection<CDNClient>();
             CDNClient initialClient = new CDNClient( steam3.steamClient, steam3.AppTickets[depot.id] );
             List<CDNClient.Server> cdnServers = null;
@@ -479,18 +481,29 @@ namespace DepotDownloader
                 }
             }
 
-            if ( cdnServers == null )
+            if (cdnServers == null)
             {
-                Console.WriteLine( "\nUnable to query any content servers for depot {0} - {1}", depot.id, depot.contentName );
+                Console.WriteLine("\nUnable to query any content servers for depot {0} - {1}", depot.id, depot.contentName);
                 return cdnClients;
             }
 
+            var weightedCdnServers = cdnServers.Select(x =>
+            {
+                int penalty = 0;
+                ConfigStore.TheConfig.ContentServerPenalty.TryGetValue(x.Host, out penalty);
+
+                return Tuple.Create(x, penalty);
+            }).OrderBy(x => x.Item2).ThenBy(x => x.Item1.WeightedLoad);
+
             // Grab up to the first eight server in the allegedly best-to-worst order from Steam
-            Parallel.ForEach(cdnServers, (server, parallelLoop) =>
+            Parallel.ForEach(weightedCdnServers, new ParallelOptions { MaxDegreeOfParallelism = 2 }, (serverTuple, parallelLoop) =>
             {
-                CDNClient c = new CDNClient(steam3.steamClient, steam3.AppTickets[depot.id]);
+                var server = serverTuple.Item1;
+                CDNClient c = new CDNClient( steam3.steamClient, steam3.AppTickets[ depot.id ] );
 
                 try
+                {
+                    for (int i = 0; i < server.NumEntries; i++)
                     {
                         c.Connect(server);
 
@@ -503,18 +516,23 @@ namespace DepotDownloader
 
                         c.AuthenticateDepot(depot.id, depot.depotKey, cdnAuthToken);
                         cdnClients.Add(c);
+                    }
 
                     if (cdnClients.Count >= Config.MaxServers) parallelLoop.Stop();
                 }
-                catch
+                catch (Exception ex)
                 {
-                    Console.WriteLine("\nFailed to connect to content server {0}", server);
+                    int penalty = 0;
+                    ConfigStore.TheConfig.ContentServerPenalty.TryGetValue(server.Host, out penalty);
+                    ConfigStore.TheConfig.ContentServerPenalty[server.Host] = penalty + 1;
+
+                    Console.WriteLine("\nFailed to connect to content server {0}: {1}", server, ex.Message);
                 }
             });
 
-            if ( cdnClients.Count == 0 )
+            if (cdnClients.Count == 0)
             {
-                Console.WriteLine( "\nUnable to find any content servers for depot {0} - {1}", depot.id, depot.contentName );
+                Console.WriteLine("\nUnable to find any content servers for depot {0} - {1}", depot.id, depot.contentName);
             }
 
             Config.MaxDownloads = Math.Min(Config.MaxDownloads, cdnClients.Count);
@@ -533,15 +551,12 @@ namespace DepotDownloader
                 ulong DepotBytesUncompressed = 0;
 
                 Console.WriteLine("Downloading depot {0} - {1}", depot.id, depot.contentName);
-                Console.Write("Finding content servers...");
 
                 var cdnClientsLock = new Object();
                 BlockingCollection<CDNClient> cdnClients = null;            
                 int liveCdnClients = 0;
                 CancellationTokenSource cts = new CancellationTokenSource();
 
-                Console.WriteLine(" Done!");
-
                 ProtoManifest oldProtoManifest = null;
                 ProtoManifest newProtoManifest = null;
                 string configDir = Path.Combine(depot.installDir, CONFIG_DIR);
@@ -817,7 +832,7 @@ namespace DepotDownloader
                             }
                             catch (Exception e)
                             {
-                                Console.WriteLine("Encountered error downloading chunk {0}: {1} (live cdn clients: {2})", chunkID, e.Message, liveCdnClients);
+                                Console.WriteLine("Encountered error downloading chunk {0}: {1}", chunkID, liveCdnClients);
                                 int liveCount = Interlocked.Decrement(ref liveCdnClients);
                                 if (liveCount == 0)
                                 {